Addon: LootDestroyer v0.60

[sarf]

EDIT:
Upgraded it to new Interface version. Optionally dependent on Cosmos (options should work now). Works for me.

Updated the unwanted item texture - thanks to OwlBoy for this much neater one! :)


The AddOn is now considered "finished" in its current form. More features may be added, but now it does what it is supposed to do.
There is still an issue with looting stuff when you have a completely full inventory and if the item you are looting is an unwanted one, but that case is considered "so rare that I'll fix it when I get some more data on full inventory messages".

Hiya!

Latest Stable Version (http://www.fukt.bth.se/~k/wow/scripts/LootDestroyer/LootDestroyer_v0.60.zip)

I decided to throw together an AddOn to facilitate the destruction of worthless things the user does not want.

If you do not have Cosmos, you will have to use the slash commands to activate it. To do so, use the following :/lootdestroyerenable on
or
/ldenable onIn case the above does not work :/script LootDestroyer_Toggle_Enabled(1);

It was inspired by Bayta's thread on the official forum (http://www.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=7202).

Download it here :
http://www.fukt.bth.se/~k/wow/scripts/LootDestroyer/

It should be rather easy to use with the looting window :
To automatically destroy an unwanted item, simply pick it up (left- or right-click).
To mark/unmark an item as unwanted, hold down shift (or ctrl) and right-click it.
Note that you can mark item as unwanted both in the looting window and by your inventory (but you need to hold ctrl if you want to do it from the inventory).

OBSERVE! NOTE! OBSERVERA! ACHTUNG!

Note that it now tries to preserve the number of items that you currently
possess when you mark the item as unwanted.


The list of unwanted items is not persistent across gaming sessions.

Possible future features:
Marking stuff as wanted/unwanted in the item window.[list:8df277cfb0] You can use the /lootdestroyeradd (or /ldadd) command to add/remove items to the unwanted items list. The new versions should have this functionality - simply hold <CTRL> and right-click an item in your inventory to toggle its presence in your unwanted items list.
CTRL is used to be compatible with Cosmos' "shift-right-click to sell" option. Checking if your inventory is full prior to queueing deletion. Creating a seperate frame which contains the "unwanted items" list.
Visual indication of what items will be deleted upon pickup. Fixed in version 36+, quantity set to X Restoring item quantity if toggling the unwanted state of an item in the loot frame Fixed in version 37+ Changing the texture of an item to one indicating that it will be destroyed. Fixed in version 38+ New shiny texture used instead of the sacrifical shield one in version 39+ Toggling unwanted items should now produce an updated LootFrame as you would expect in version 43+ Handling looting of items with more than 1. Fixed in version 32+ Working with Blizzards loot all command Fixed in version 52+[/list:u:8df277cfb0]

I'd appreciate feedback, bug reports and compliments!

Sarf
---
I'm as confused as a baby in a topless bar.

[Anonymous]

...and then the game crashed, but it didn't the first time, so I'm not sure if this is related or not?

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)
--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 145
Error : `)' expected near `='

Looking forward to going on a little leather farming expedition to give this a workout :)

[sarf]

Oops! My bad. Updated the code so that the lua should be error-free... or at least, be possible to load.

Sarf
---
CYNIC, n. A blackguard whose faulty vision sees things as they are, not as they ought to be. Hence the custom among the Scythians of plucking out a cynic's eyes to improve his vision.

[karconn]

...but I have a new error, I'll just keep them rolling as you fix them, pretty excited about this, I'm not sure if people see the need for it now, but the first time your 51st level leatherworker and skinner needs to go 'shopping' for low level hides to make a set of armor for your hunter from 10th to 20th level and you need 50 light and medium hides, we'll all be singing your praise :p

I came in and saw the 'disabled' message, on a whim I went to see if there was a toggle in the Cosmos options and there was (else I was going to use the 'short commands' I saw in the lua (/ldenable, lddisable, ldlist, etc)...but the toggle worked. I did an /ldlist and saw I didn't have anything in the list.

Ran out to kill a wolf, he had a paw so I went ahead and looted it (it was a high level wolf and that paw was worth decent money, realized I was going to need to migrate to a newbie zone for the test - I can't stand seeing even a silver wasted). I 'left clicked' to loot the paw, no errors.

I then skinned the wolf and 'right clicked' to loot the pelt and received the following error:

String : Interface\AddOns\LootDestroyer\LootDestroye...
Line : 188
Error : bad argument #2 to `format' (string expected, got nil)

Presumably because my filter list is empty? I dunno, didn't look at the code, it was just something that jumped out at me as being possible. At your point in testing, you probably have a list of items all setup, and haven't tested it from a clean slate, which is where I come in :)

Like the forums, are these new? Or am I just lazy :)

[sarf]

The bug was a stupid one - I referred to one variable when I should have referred to another. I've uploaded the new version.

The forums are pretty old (they were here when this place was called WoW Mods), but not many people uses. I use them because I lack a WoW account - something that hopefully will be remedied soon by the European beta.

Oh, and I hope you are aware of the instructions - right-clicking in the LootFrame means that the item will be designated as unwanted. If you want to, I can make it so that you have to shift-rightclick for that.

Sarf
---
CLOSE-FISTED, adj. Unduly desirous of keeping that which many meritorious persons wish to obtain.

[karconn]

Oh, and I hope you are aware of the instructions - right-clicking in the LootFrame means that the item will be designated as unwanted. If you want to, I can make it so that you have to shift-rightclick for that.

I would say we'd want to have to do something 'above and beyond' what is standard to mark an item as filtered. I have gotten used to left clicking and/or right clicking to pick things up in many instances just because I can. I would have accidentally marked 'Thick Leather' in my filter :(

I like the shift idea, or any key combination. Shift might be bad because that is also a sell thing right? Or is this 'just' coded for the loot frame?

Question: How do you remove something from the filter? Do you have to use the slash commands? Or is it documented in the header of the lua file, I can go read that again? I skimmed it rather quickly the first time.

And here's to hoping you folks get your beta soon!

[sarf]

I would say we'd want to have to do something 'above and beyond' what is standard to mark an item as filtered. I have gotten used to left clicking and/or right clicking to pick things up in many instances just because I can. I would have accidentally marked 'Thick Leather' in my filter :(
Acknowledged. Fixed in the newest version.

I like the shift idea, or any key combination. Shift might be bad because that is also a sell thing right? Or is this 'just' coded for the loot frame?
This is just for the loot frame.

Question: How do you remove something from the filter? Do you have to use the slash commands? Or is it documented in the header of the lua file, I can go read that again? I skimmed it rather quickly the first time.
Simply toggle it again, or use the slash commands. If you use Cosmos, /chelp should provide documentation about Cosmos slash commands. I don't know how you get documentation about slash commands without using Cosmos, but it is possible.

And here's to hoping you folks get your beta soon!
Heh... most (read: all but me AFAIK) Cosmos people have access to the beta... but thanks anyhow! :)

Sarf
---
CLAIRVOYANT, n. A person, commonly a woman, who has the power of seeing that which is invisible to her patron, namely, that he is a blockhead.

[karconn]

I've tried everything I could think of and I can't seem to figure out how to add something to the filter list. I've shift-clicked, shift-rightclicked. In the loot frame and in my bag, and nothing seems to work. I do an /ldlist and there's nothing there, and I keep picking things up.

[sarf]

Alright. If all else fails, you can add things manually to the list by using the following slash command :/ldadd itemname

I've put up a new version that may or may not work in adding stuff (shift and right-click).

Sarf
---
If there is a wrong way to do something, most people will do it every time.

[karconn]

Shift-right click now works to add an item to the list.

If I 'right click' to loot an item out of the loot frame, it does not pass it through the filter, and I get the item in my bag.

If I 'left click' to loot an item out of the loot frame, I get the following error:

String : Interface\AddOns\LootDestroyer\LootDestroye...
Line : 321
Error : attempt to index field `?' (a nil value)

[sarf]

Aha!

Alright, let me check... <humdiididum> <more pause music>

<WHAM> <BONK> <SLAM> <THUD> <MEEEEEEOW>

Done.

By the way, is it OK if only left-clicking uses the LootDestroyer, should it be a toggle, or should LootDestroyer always monitor both buttons?

Sarf
---
Greatness is a transitory experience. It is never consistent.

[karconn]

Aha!

Alright, let me check... <humdiididum> <more pause music>

<WHAM> <BONK> <SLAM> <THUD> <MEEEEEEOW>

Done.

By the way, is it OK if only left-clicking uses the LootDestroyer, should it be a toggle, or should LootDestroyer always monitor both buttons?

Sarf
---
Greatness is a transitory experience. It is never consistent.

So much for 'no cats were destroyed during the making of this mod'! Good thing the baseline cat is only 40s :)

Uhm...I'd like both because I use both, as I'm sure many others do. Especially being a skinner, we right click to skin, so as soon as you figure out that right clicking will also loot, you turn into the 'Right Click Kid' - being a skinner anyways :) Why flip back and forth between the two when you can right click like crazy on a corpse and eventually get everything you need? :)

So...if you are going to monitor right clicks too, then I'll wait for that version :)

IRC became a real hassel for me :( When it got the point where it told me to uninstall my Symantec Small Business Anti-Virus, I really got turned off :shock:

[sarf]

OK, done. Should now catch and destroy loot using both buttons.

Ah... didn't know you had to lower your firewall for IRC. :/
Then again, reverse DNS will probably do that...

Sarf
---
Let a fool hold his tongue and he will pass for a sage.

[karconn]

Ok, the shift-rightclick works to add now, and right clicking also allows it to perform the filter check, excellent! (I need to go back and test all the left clicking too, haven't done that yet)

There's an odd thing happening, and I'll tell you about that, but it made me think of another issue. So...I guess the problem first.

I had 6 med leathers in my bag and decided on the next one to add it to my 'list'. I shift-rightclicked, it said it added it, but it gave me the leather and I now had 7. I would think it would have destroyed that one and I'd still only have 6 at that point, but it gave it to me. So I thought, "ok, it'll start 'after' the current loot, no problem"...

So I got my next med leather and I had my bags openned when I looted it after skinning and what it did was delete my 'entire' stack of 7 med leathers, and then gave me the new leather. The 'next' med leather loot it just gave to me, so I had 2. Then every subsequent loot would work the same way: If there was one item in my bag, it'd give me two. If there were 'more' than one item in my bag, it'd delete the stack, but give me the loot so I was back to one.

The new concern I have is it retroactively deletes. It's not just looking at 'from this point forward'. So it doesn't say 'she just looted 1 med leather, I will find 1 med leather in her bag and destroy it'. It seems to be doing something else. So, if I decided while I was out skinning that I just want to collect med leathers, but maybe I should take 1 stack of 20 light leathers back, I can get to 20 and 'then' add a light leather to the list.

And related to that, I suppose if it were possible, it should filter from the point you add it. So at the time I do the shift-click to add that to 'the list', I shouldn't get that item...but that behavior could just be related to the other behavior, I dunno.

What do you think about that concern though, the way it retroactively will delete anything in the list? I don't think it should delete what you already have, just anything you are picking up from that point forward.

Two things it appears to be doing:
1) It actually does the check 'before' the new item hits my bag. Which would explain why I always get the first one.
2) It doesn't do just 'one' item, it wants to kill an entire stack.
3) I am unclear as to why it does 'nothing' when 'one' stackable item exists in the bag. That is, it doesn't remove until there's 2 or more...but then of course it gives me a new item, since the delete seems to occur before I actually get anything.

Hope that helps :)

[sarf]

Ok, the shift-rightclick works to add now, and right clicking also allows it to perform the filter check, excellent! (I need to go back and test all the left clicking too, haven't done that yet)
Well, the left-clicking and the right-clicking share the same code, but still, I'd appreciate it. Thanks, by the way! It's always fun to hear that your stuff works... partially, anyhow. :)

And related to that, I suppose if it were possible, it should filter from the point you add it. So at the time I do the shift-click to add that to 'the list', I shouldn't get that item...but that behavior could just be related to the other behavior, I dunno.
The problem is that I can't prevent you from getting the item, so instead I look for the last instance of "an item in your inventory whose item name matches the unwanted item you just clicked on".

What do you think about that concern though, the way it retroactively will delete anything in the list? I don't think it should delete what you already have, just anything you are picking up from that point forward.
It will not kill more than that one item, or rather, that stack of items which matches the last item you clicked on.

Two things it appears to be doing:
1) It actually does the check 'before' the new item hits my bag. Which would explain why I always get the first one.
Probably correct. I will attempt to correct this real soon now (but wanted to give you a heads-up).

2) It doesn't do just 'one' item, it wants to kill an entire stack.
Yes. Until I figure out how to delete less than one stack, or rather, one "inventory slot", I can't delete any less than one stack. I have an idea, however...

Test number one:
Make sure that in the very first slot in the very first bag (your backpack) you have a stack of items. Type in the following in the edit box and press <ENTER>. :/script SplitContainerItem(0, 1, 1); Report back what happens. If all goes well, the item in question should end up on your cursor.

3) I am unclear as to why it does 'nothing' when 'one' stackable item exists in the bag. That is, it doesn't remove until there's 2 or more...but then of course it gives me a new item, since the delete seems to occur before I actually get anything.
Please report what the tooltip says about "one item" and what it says about the stack (the first line is the important one)... but basically, it might not match the singular form, when there is only one item. I might be able to fix this, however, it will have some risks (I may match other things as well).

Sarf
---
If all those psychics know the winning lottery numbers, why are they all still working?

[karconn]

Ok, the SplitContainerItem test. I tested with one item (not yet stacked) and that gave me 'the' item on my cursor, which I could place somewhere else or whatever.

I tried it when the stack had 'two' items in it and it split it and just gave me one, which I could place wherever. So that seems like that would work good.

I see what you mean about the stacks. But in theory, if the code is fixed to it really fires 'after' you receive the item, 'and' you figure out how to deal with stacks, the issue should go away. If I had a stack of 15 items, I'd then get 16, and then you'd pull just one item off it and delete it.

I think all the pieces are there, getting close, and it's going to be great :)


Note: I didn't understand "Please report what the tolltip says about 'one item' and what it says about the stack (the first line is the importan one)"? Was I supposed to do another test?

[sarf]

Yes.

Basically, what pops up when you mouse over something is a tooltip.

Please see what differences you see in the tooltip when you have one item and when you have more than one item.

I need to know if the first line is different in the two cases.

Sarf
---
"If you're not part of the solution, be part of the problem!" - consult motto

[karconn]

Yes.

Basically, what pops up when you mouse over something is a tooltip.

Please see what differences you see in the tooltip when you have one item and when you have more than one item.

I need to know if the first line is different in the two cases.

Sarf
---
"If you're not part of the solution, be part of the problem!" - consult motto

Ok...there is no difference in the name of the stack, whether it has one item or many. 'Naga Scale' was my example, and whether I mouse over one or a stack of 3, it's still called 'Naga Scale'. If that is what you wanted to know.

[sarf]

Yes, it is. Thanks.

Download the new version and try it out!

Sarf
---
Cows.

[karconn]

Some new interesting issues...

1. Shift+LeftClick does 'not' add items to the list, only Shift+RightClick
2. When I right click to loot now, it doesn't seem to be filtering it at all.
3. When you set an item to not be looted, you still get it the first time. It does not remove it.
4. Fun new issue: So the first time you mark it, you get the item. The second time you loot (left click only, right isn't working per above), you get this stack of 2 items that is 'greyed out'! I can see it, it looks like it's in a state where it's in a trade window waiting for a cancel or to complete the trade kinda thing. I can't move it or delete it...kinda scary. If I then left-click loot a 'third' item in that stack, it puts it in the stack and I have 3 items now, and can once again move my stack around.

Interesting :)

[sarf]

1. Shift+LeftClick does 'not' add items to the list, only Shift+RightClick
<sigh>
When did I say it would? Anyhow... nope, I do not use Shift+LeftClick since that used (and still is) used to plop out links to the items into trade channels. Sorry for the misunderstanding.

2. When I right click to loot now, it doesn't seem to be filtering it at all.
No... "seems to be" is the operative phrase here. I'll recode the text output though so it looks like its doing more.

3. When you set an item to not be looted, you still get it the first time. It does not remove it.
Well... I gotta go see if I need to do some recoding of the item recognition code.

4. Fun new issue: So the first time you mark it, you get the item. The second time you loot (left click only, right isn't working per above), you get this stack of 2 items that is 'greyed out'! I can see it, it looks like it's in a state where it's in a trade window waiting for a cancel or to complete the trade kinda thing. I can't move it or delete it...kinda scary. If I then left-click loot a 'third' item in that stack, it puts it in the stack and I have 3 items now, and can once again move my stack around.
I believe this is caused by the SplitContainerItem function.


WOOOOOOOOOOOOOOOOOOOO!

I think I found the bug. Sorry. I didn't register an event. My bad.

Check out the new version.

Sarf
---
Everything in excess! To enjoy the flavor of life, take big bites.

[karconn]

Ok, looking really good now :D

Only shift-rightclick adds to the list, and that makes perfect sense as to why you'd have to do it that way, but honestly, I think the shift-rightclick is more natural anyways.

Now, 'before' right click was 'honestly' not working when looting. It wasn't passing it through 'the list' like left click was...but whatever you did this time has fixed that! Both left clicking and right clicking 'filter' the item. I see your little messages now (which you can probably remove) when looting. I see the item go in the stack, and then it's removed. It doesn't blow away items that exist prior to me adding them to the list. The only exception I could foresee is if you tried to loot something and didn't have room, might it remove one? Probably, but oh well :)

The last little itty bitty gripe I have is that when you 'first' shift-rightclick to add it to 'the list' (and I'd keep the notification when you add it to the list), it still adds into your bag. I think that first time when it's added to the list it should also delete it. But it's a minor thing, it just means you have to manually delete the first item you add to the list.

But other than that, it seems to be working great! If you elect to try to figure out how to purge the first item as it's added to the list, let me know and I'll test that too. If not, I look forward to it showing up in Cosmos alpha :D

Thanks for your hard work!

[sarf]

Ok, looking really good now :D
Heh, not bad for a few patches between fights in CoH, now is it? :) (obvious fishing for compliments :) )

Only shift-rightclick adds to the list, and that makes perfect sense as to why you'd have to do it that way, but honestly, I think the shift-rightclick is more natural anyways.
Thanks. If you should want any other kind of clicking, do tell.

Now, 'before' right click was 'honestly' not working when looting. It wasn't passing it through 'the list' like left click was...but whatever you did this time has fixed that!
Yeah... basically, before, left-clicking used the old code (delete prior to item being delivered to inventory) and the right one added the item to a list that never got used.

Both left clicking and right clicking 'filter' the item. I see your little messages now (which you can probably remove) when looting. I see the item go in the stack, and then it's removed. It doesn't blow away items that exist prior to me adding them to the list. The only exception I could foresee is if you tried to loot something and didn't have room, might it remove one? Probably, but oh well :)
Yeah... unless I figure out a way to get the "Not enough room in your inventory"-message that I suspect WoW shows you.

The last little itty bitty gripe I have is that when you 'first' shift-rightclick to add it to 'the list' (and I'd keep the notification when you add it to the list), it still adds into your bag. I think that first time when it's added to the list it should also delete it. But it's a minor thing, it just means you have to manually delete the first item you add to the list.
Manual deletion? We can't have that! :) Fixing this now.

But other than that, it seems to be working great! If you elect to try to figure out how to purge the first item as it's added to the list, let me know and I'll test that too. If not, I look forward to it showing up in Cosmos alpha :D
Well, it's not as much "figuring out" as remaking a bit of code.

Thanks for your hard work!
Thanks for yours! It's not easy being a betatester for a coder that can't test his code... but you've done great!

Sarf
---
"Once something has been approved by the Government, It's no longer immoral." - Reverend Lovejoy

[karconn]

Just tried out 0.29. Seems to be working good. Had a stack of 9 items, shift-rightclicked to add it to the 'no-no' list and it added it to the list and removed it in one shot, leaving me with a stack of 9 :)

[sarf]

Great! I can probably move this to the "finished" pile, then.

Sarf
---
If this is paradise, I wish I had a lawnmower.

[sarf]

I've created a new version that allows you to mark things as unwanted by right-clicking them in the inventory screens. Try it out and see if it works, if you would be so kind.

Sarf
---
If genetic scientists crossed a chicken with a zebra would they get a four-legged chicken with its own barcode?

[karconn]

Got this when I did a 'reloadui':

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)
--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 306
Error : unexpected symbol near `;'

Is it going to be 'shift' right clicking in your bags? What happens if you are selling? Default to sell is right click, and then I know you folks have a shift right click to sell, I don't use that, but was wondering if this would conflict or otherwise be confusing?

[sarf]

Got this when I did a 'reloadui':

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 306
Error : unexpected symbol near `;'
Sheesh... stupid me. Fixed this bug.

Is it going to be 'shift' right clicking in your bags? What happens if you are selling? Default to sell is right click, and then I know you folks have a shift right click to sell, I don't use that, but was wondering if this would conflict or otherwise be confusing?
Ehh.. you're right. While I have disabled the unwanted item toggling while trading, it could be confusing.
Tell you what, I'll switch to control clicking stuff in your inventory, and shift OR ctrl-clicking in the loot frame. More flexibility is good for you. :)

Sarf
---
If you had a million Shakespeare's, would they write like a monkey?

[sarf]

Hopefully the bugs are fixed and it works. If it doesn't, use the Latest Stable Version (0.29, link provided in first message).

I need to get to sleep now, as I should be up and about in about 7 hours.

I'll get back to coding tomorrow afternoon (hopefully).

Sarf
---
Do you need a silencer if you are going to shoot a mime?

[karconn]

ctrl clicking works great, and I tested it as the toggle from the main bag and other bags, killed a few more things, made sure it was still filtering when it should.

question: is this persistent? per account? per character? I can't imagine you'd want it to be, unless you had some kind of virtual alergy to particular loot. I seem to only want it as an exception. Maybe I need to fight in a place for a really long time to collect some items, and want to keep only the 'best' loot. Or I'm just out leather farming, I'll start adding all the common things to a temporary list while I farm (tiger teeth, meat, etc). Can't think of a reason I'd ever want that saved between sessions?

But it seems to be working great :)

[sarf]

The list of unwanted items is not persistent across gaming sessions.
... and I might be inclined to add this, but not right now, and probably not never - the amount of problems it would cause is simply not worth it.

Glad to hear it works for you - I'll keep 0.29 the "Stable" version for a while longer though until I am sure there are no more bugs in it.

Sarf
---
How do 'Do Not Walk On Grass' signs get there?

[sarf]

Added visual identification of things that will be deleted (the infamous quantity string will be displayed and set to X).

Fixed the issue when you loot an item with a quantity above 1.

Sarf
---
Happiness is mandatory. Are you happy?

[karconn]

Get this when trying to load (so I rolled back to .31):

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)
--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 404
Error : <eof> expected near `end'

[sarf]

oops.

Fixed.

Sarf
---
Drive carefully. 90% of the people in the world are caused by accidents.

[karconn]

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)
--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 317
Error : unexpected symbol near `4'

[sarf]

New version up.

34

Sarf
---
Girls will be boys and boys will be girls

[karconn]

Ok it loads, and I see the item is in brackets now, was that supposed to be clickable, or just set aside in brackets to be easier to read?

[sarf]

Brackets?

When? ooh... You mean when you add/remove items?

It should always have been with brackets... and yes, it is to make it easier to read.

Sleepytime.

Sarf
---
And where you are ain't no good unless you can get away from it

[karconn]

What should I be testing for in the new version? :D

[sarf]

What should I be testing for in the new version? :DWell... does it work? Will it show the little "X" on the things it will delete? Does its options save?

Anyhow, it's not urgent, as I am going to bed (really!). :)

Sarf
---
A person who smiles in the face of adversity...probably has a scapegoat.

[karconn]

little x, hmm

well the setting for loot destroyer has 'always' saved and been in my cosmos menu, that part has always worked :)

little 'x'? guess i'll look for an x :)

[sarf]

It should be where the "number" of items in the loot frame normally appears.

Sarf
---
You do not need a parachute to skydive. You only need a parachute to skydive twice.

[karconn]

oh, like if the stack is more than 1? so i need to kill something that gives me a stack of more than one item?

last time i saw that was black whelp scales...i don't see things like that often? I'll have to think about what I need to slug to get that to show up for me :D

night!

[sarf]

oh, like if the stack is more than 1? so i need to kill something that gives me a stack of more than one item?
Nonono. :)

What I mean is that the "X" appears at the same place (I basically use that same UI element). When the X appears, you know that the item in question will get LootDestroyed (unless you unmark the object). So it has nothing really to do with item stack size. :)

Sarf
---
The trouble with ignorance is that it picks up confidence as it goes along.

[sarf]

WONGA!

Found a bug which would prevent the "X" from being displayed.

Also updated the code so that it will refresh the LootFrame window if you mark/unmark stuff, thus allowing you to test it easier (by having one item which is present in the loot frame in your bag and marking/unmarking it).

Sarf
---
Don't use a big word where a diminutive one will suffice.

[karconn]

ok i'll go get it now go to sleep!

I'm not going to respond until tomorrow so you don't work on it :p

[sarf]

Alright, new version up with mostly cosmetic fixes. Will now restore the quantity of items in the loot frame which it previously left set to "X".

Sarf
---
If Goddess had intended humans to smoke, She would have set them on fire.

[karconn]

I'll go try this, but I'm still not getting the 'x' thing :(

Can you give me a scenario to look for, try?

[sarf]

I'll go try this, but I'm still not getting the 'x' thing :(

Can you give me a scenario to look for, try?
Basically, farm for something that will, eventually, drop more than one item of the same kind (for example 2 linen or what not). Make sure that you have some linen in your inventory. While the LootFrame is visible (and has linen in it) toggle the linen as an unwanted item (by using the ctrl-click at the linen in your inventory).

You should see an "X" replace the "2" in the LootFrame (if it were 2 linen, of course) - however, you may need to have the latest version for that.

Anyhow, I'm making a new version that will replace the texture (icon) of the item instead of just the quantity... that should be easier to see.

Sarf
---
Studying stuff for reports is not fun.

[karconn]

Ok my character has a few 'errands' to run, but I'll check for a new version when I get to place where I can put this to the test. I guess linen is a good thing to do, one of the few things I can think of off hand that drops in bunches :)

[sarf]

New version up with custom designed loot icon replacement and everything.

Sarf
---
Climate is what we expect, weather is what we get.

[karconn]

Ok I get it now.

What I see is a big X instead of the icon. Now, were you expecting it to toggle 'real time' in the loot frame as I ctrl-rightclicked on the corresponding stack in my inventory? It doesn't seem to do that. Whatever icon it should have when you first open the loot bag is what it will stay at. So if I have silk in my do not loot list, and open the loot frame, I see the X. I can toggle the silk in my pack in/out of the list and the icon does 'not' change in the loot frame.

If I toggle silk 'out' of the list, the 'next' time I loot silk, I see the standard icon.

So if that was the anticipated results, then it works :)

[sarf]

Ah.

<BONK WHACK THONK>

Misspelling by me yesterday. It will probably work now.

Grab the latest version and see if it works. I'll fix the extra toggle options for more user interface customizability "later".

Sarf
---
I must have a prodigious quantity of mind; it takes me as long as a week sometimes to make it up.

[karconn]

That's pretty slick :) It does everything on the fly. If I add something to the list from the lootframe, it changes icons, and then I see it come into my bag and delete quick.

One glitch.

If I have bear meat in my bag and it's not in the list yet, and I have a lootframe open and there's bear meat in it as well, and I add it to the list, the icon changes in the loot frame like I'm assuming you want it to (the whole loot frame moves too, but that's a side effect of having quick loot on).

Given the same situation (bear meat in bag, bear meat in loot frame), but the bear meat is already in the list, the icon in the loot frame is the X to start. If I toggle it 'out' of the list from my bag, the icon does 'not' change back from an X. I have to close the loot frame and re-open it to see the icon changed back.

So it works from item std icon to X, but not from X back to std icon - from a 'real time' perspective...if that makes like any sense at all? :)

But that's kinda neat, certainly no errors or anything, and that was a neat idea making the icons so you know they will be deleted.

[sarf]

That's pretty slick :) It does everything on the fly. If I add something to the list from the lootframe, it changes icons, and then I see it come into my bag and delete quick.
Great!

Given the same situation (bear meat in bag, bear meat in loot frame), but the bear meat is already in the list, the icon in the loot frame is the X to start. If I toggle it 'out' of the list from my bag, the icon does 'not' change back from an X. I have to close the loot frame and re-open it to see the icon changed back.

So it works from item std icon to X, but not from X back to std icon - from a 'real time' perspective...if that makes like any sense at all? :)

But that's kinda neat, certainly no errors or anything, and that was a neat idea making the icons so you know they will be deleted.
Ah. My bad, try and see if verson 0.41 fixes this.

Credits for the idea to change the texture comes from the nice chaps at the cosmostesters channel on IRC - it sounded neat and it's good that it works!

Sarf
---
ELOQUENCE, n. The art of orally persuading fools that white is the color that it appears to be. It includes the gift of making any color appear white.

[karconn]

.41, the following error on load :(

String : LootDestroyerFrame:OnLoad
Line : 1
Error : attempt to call global `LootDestroyer_OnLoad' (a nil value)
--------------------------------------------------
String : Interface\AddOns\LootDestroyer\LootDestroyer.lua
Line : 347
Error : unexpected symbol near `='

[sarf]

.41, the following error on load :(
[report]
Thanks for the report - I've fixed the bug in the new version. I made a mistake... probably from being too tired. Fortunately, I've recently recuperated from an eight hour sleep (my first in a week! yay!), so I will hopefully not make more mistakes such as this one.

Sarf
---
How do I set my laser printer on stun?

[karconn]

blech lost my whole post, cable went down again :(

The error is gone, but it's behaving no different from .40

It's almost like the 'removing from the list' process when performed in the main bag does not cause any events to be fired in the lootframe. But adding to the list from the main bag does cause events to fire in lootframe. Probably not making any sense, but that's what it looks like.

[sarf]

Hmm.

OK, I located another possible error source. Try version 0.43 now.

Thanks for your patience, by the way!

Sarf
---
"If debugging is the act of removing bugs from code, programming must be the act of putting them in." - Dykstra Sr.

[karconn]

Same :)

Just seems like when you are removing an item from the list 'from your back pack', the loot frame doesn't seem to know or care about it. When you are adding it from your backpack, it wakes up and changes the icon just fine.

Oh no biggie, doesn't take me much to go play and every half hour or so see if you don't have a new update to try. I started the nonsense, might as well help you finish it with all the other enhancements :p

[sarf]

Same :)

Just seems like when you are removing an item from the list 'from your back pack', the loot frame doesn't seem to know or care about it. When you are adding it from your backpack, it wakes up and changes the icon just fine.
Well, actually, I have a problem with retrieving the old texture - the one that the item originally had.

Try the new new version, it might work or might cast some light on the situation.

Sarf
---
Tongue-tied and twisted, just an earthbound misfit, I.

[karconn]

Well...what you said makes perfect sense, you don't know what the image was before it was added to the list, so I tried this, and it doesn't do anything different or new that I can tell, still works great, just doesn't turn the icon back 'real time' if you have a lootframe open, which isn't a big deal I suppose. You get the confirmation in the chat when things are removed from the list, so you'll know you'll get it.

Here's a thought, but maybe this is not doable or too much overhead. Can you identify what graphic is being used 'before' you change it and store it in an array along with the items in the list?

But given that you feel it's not possible or don't think it's worth it (I'm not certain it is either), I think the dishes are done! :)

And thanks again, these all came out great! Least the ones I got to test and was really interested in. I'm especially glad you implemented Telo's ALT-Sef casting. It's sooo much cleaner than what I was using before, and allowed me to get that last bit of 'monkey code' I had out of that file so I have nothing but clean Cosmos running now :)

...and on another note, I have 'no' idea why everyone gets all bent out of shape about Cosmos, and make it stable and blah this and blah that. I like it, and maybe it's 'because' I enjoy more of the foo-foo stuff than the militant "can I have 23 button bars fill up my screen" folks.

So keep up the good work...and the foo-foo :)

Oh, and tell GotMoo thanks again for doing the targetdistance :)

[sarf]

Well...what you said makes perfect sense, you don't know what the image was before it was added to the list, so I tried this, and it doesn't do anything different or new that I can tell, still works great, just doesn't turn the icon back 'real time' if you have a lootframe open, which isn't a big deal I suppose. You get the confirmation in the chat when things are removed from the list, so you'll know you'll get it.
Ah... no change, then.

Here's a thought, but maybe this is not doable or too much overhead. Can you identify what graphic is being used 'before' you change it and store it in an array along with the items in the list?
That's what I have been doing. :( It just won't restore the texture... or maybe it won't recognize that it has changed.

Anyhow, a new version has been put up. It will change back the texture to the old one regardless as to what texture it currently is.

But given that you feel it's not possible or don't think it's worth it (I'm not certain it is either), I think the dishes are done! :)
Heh... I hope to fix the last issue, release a v1.0 and then move on to other AddOns.

And thanks again, these all came out great! Least the ones I got to test and was really interested in. I'm especially glad you implemented Telo's ALT-Sef casting. It's sooo much cleaner than what I was using before, and allowed me to get that last bit of 'monkey code' I had out of that file so I have nothing but clean Cosmos running now :)
Thanks! :)

...and on another note, I have 'no' idea why everyone gets all bent out of shape about Cosmos, and make it stable and blah this and blah that. I like it, and maybe it's 'because' I enjoy more of the foo-foo stuff than the militant "can I have 23 button bars fill up my screen" folks.
Yeah... most people seem to think that errors in the Alpha are the end of the world as they know it, or something. :)

So keep up the good work...and the foo-foo :)

Oh, and tell GotMoo thanks again for doing the targetdistance :)
I sure will! See you around on the forums!

Sarf
---
Signature Not Available

[karconn]

I get the following error on .45


String : Interface\AddOns\LootDestroyer\LootDestroye...
Line : 369
Error : bad argument #3 to `format' (string expected, got nil)


This occured as 'soon' as I loot something, every time I loot.

[sarf]

Much revamped version 0.46 up now. Might even work (well, except for a few nils here and there... :) ).

Thanks for the bugreport!

Sarf
---
It's hard to be religious when certain people are never incinerated by bolts of lightning.

[karconn]

Hope I did my bug report right and it wasn't a dupe :)

Still getting this error (or...new error, guess I didn't compare it to the one above real close). How about...I get 'an' error still :)


String : Interface\AddOns\LootDestroyer\LootDestroye...
Line : 345
Error : attempt to call method `GetTexture' (a nil value)


Happens whenever the lootframe is openned.

[sarf]

Alrighty. Thanks!

<BONK>

Should be fixed now. No more niceties, this version does what its supposed to (hopefully) without many checks and assumptions.

Sarf
---
CLOSE-FISTED, adj. Unduly desirous of keeping that which many meritorious persons wish to obtain.

[karconn]

Ok...no more errors, back to where it was, but :(

Multiples doesn't work :(

If I get a stack of 2 or more items, it only removes 1 from the stack it seems, after it hits my bag.

[sarf]

New version with feedback updated and printing up.

Try it and see what it says when you delete an item with quantity > 1.

Sarf
---
"When you put 'THE' and 'IRS' together, it forms 'THEIRS'" - Thraken (http://www.bash.org/?37084)

[karconn]

hmm...


Linen Cloth [2] has been added to the remove queue.
[Linen Cloth] has been removed from your inventory.
[Linen Cloth] has been removed from your inventory.


And if I have a stack of 2, I see it go to 4 quickly (but disabled looking) and then it goes to 3. I wonder if the code fires to quickly? What about a half a second pause, or even 2/10ths, between deletions? I dunno?

[sarf]

Aha. Probably correct.

Time to do some scheduling code of my own.

However, a question : the texture swapping works now?
That is, the X turns back into the correct picture now?

Sarf
---
Information Highway Roadkill

[sarf]

New version up. Some extra code added that should fix the issue.
A possible (but probably unlikely bug) may occur in which multiple items (more than was specified) could be deleted. Please tell me if this happens (duh! :) ).

Sarf
---
True genius is actually 1% inspiration, 2% perspiration, and 97% bullshit.

[sarf]

I've updated it.

It now will try to keep the number of unwanted items to a certain level.
That level is specified when you mark an item as unwanted. This means that to keep 0 items of a certain kind, you will need to specify it as unwanted in the LootFrame or using command-line commands.

Sarf
---
No quips today!

[Magnis]

I searched the 5 pages for "ignore," please excuse me if this has already been asked. Is it possible to shift+right_click a mob but leave the unwanted items on the corpse? This way, we can tell party members what's on it for them to have than deleting it? ex: warriors telling mages there's a mana potion in there.

[sarf]

No. It would be possible to do this if you open the lootframe (basically, I'd "skip over" the unwanted items... hmm... not a bad idea that), but when you shift-rightclick, the lua code is not involved in grabbing the items as far as I know. This of course means I can't control what items are grabbed.

Sarf
---
"Get your facts first, then you can distort them as you please." - Mark Twain

[sarf]

By the way, I've worked on the LootDestroyer, the "repository" version has more features and works, overall, better, with an easier way to drop the "preserved count" to zero.

Sarf
---
Oh, my God! ARTHUR, I HAVE POCKETS!

[skyesfury]

Any chance we can get this updated for the current patch?
I can't find one that's compatible with cosmos.
I'd do my own, but I'm the village idiot when it comes to code.

[sarf]

Replace the ## Interface : XYZ! with ## Interface : 4114 in LootDestroyer.toc.

Sarf
---
Penguin lust!

[Anonymous]

sarf,

Thank you for taking the time to write this software. I've been using LootDestroyer rather consistantly and have made a few changes to the code in order to make things run more smoothly. Here is an outline of what was changed. Please let me know if you'd be interested in reviewing this version for use of the whole or parts of it.

------------------------------
Changes:
----------
Autosave feature added (cosmos checkbox added, but not working?)
Added slashcommands for non-cosmos (/ldautosave) and for cosmos functionality. The slashcommands seem to work fine.

Fixed destroying item when it was marked then unmarked for destruction.

Changed from a full inventory check to storing data locally and only updating bag data as it changes.
This requires storing slightly more information locally, but will be minimal increase in memory usage.
Also adds an extra single bag check every 10th run to consistantly verify data is maintained.

Items will no longer be deleted multiple times. There is a 0.5 second time limit before it can be destroyed again.

Items can destroy a stack of itself (instead of 1 at a time) depending on the if preservation is on and the total count of an item vs the count of that single stack, etc.

Todo
----------
Detect if a bag changes(mainly for new slots). Force a complete reinitialization of bag data if this happens?

------------------------------

I've been running it for some time and the debug data seems good and it runs great. I never use the preserve items option, but I did attempt to program it to maintain full functionality with this option. Not using it, I haven't tested that functionality though.

The only thing that would need to be done as far as I can see is a review of why the new checkbox for autosaving isn't running correctly.

--V

[sarf]

Please feel free to submit the code to me, and I'll prolly incorporate it (with credits of course :) ).

Due to lack of personal interest in the AddOn, I haven't developed it much (I no longer have a high-level rogue to farm stuff with :) ).

Sarf
---
Life is sometimes like a pizza round: hot, greasy, and delivered by a guy named 'Tony'.

[Stormblade]

What is the status of this? I'm interested in this new version. Some of those changes I'd really like to be using.

[sarf]

I have basically given over development of LootDestroyer to Vaejor (at least, that is my intention), since I am too busy with other AddOns (and since I like having work done for me, heh heh ;) ).

Unfortunately, due to the fact that my mail / file server has crashed (and it's not located where I can fix it)...

Well, hopefully Vaejor will get on it. :) If all else fails, I may do one last update of LootDestroyer (apart from changing the interface #s later on).

Sarf
---
Do not disturb me. I'm disturbed enough already.

[Anonymous]

Hiya!

Latest Stable Version (http://www.fukt.bth.se/~k/wow/scripts/LootDestroyer/LootDestroyer_v0.54.zip) (updated with even newer patch Interface version)



I do so hate to be a pain, but i'd LOVE to try this out. However, i am getting an error 403 (not authorized) when i attempt to download. Any ideas? So very many thanks in advance!

[sarf]

Should be fixed now. The student network went down over the weekend. :(

Sarf
---
I don't have a drinking problem... I drink, I get drunk, I fall down. No problem.

[Saskya]

Thank you Sarf! I was wondering about this as well.

Crazy servers, eh? *grin*

[Saskya]

Hm. I am getting a 'version mismatch' error on this addon. I've browsed through the thread and through quite a bit of the rest of the forum, and if i am not mistaken the 'usual' fix is to change the version # in the .toc file. I've tried this, but to no avail. Any other suggestions?

Thanks in advance for your help! Tis muchly appreciated!

[Stormblade]

Still hoping for an update to this. As I'm now 60 it's become VERY useful but currently it lags me greatly whenever I loot. Some of the changes I saw seem like they would help fix that. No full inventory check and storing it locally for example may help the lag I get.

[Anonymous]

Well judging from the responses I'm gonna guess that this addon is pretty much no longer supported. Shame because I really wanted to use it but as it is right now I can not. The lag it introduces is not major but enough to be very annoying.

If you ever get this going again it'd be great.

[sarf]

Hopefully my website will not FUBAR very much and I can put up a new version (using DD library) that should prove less laggy.

Sarf
---
All in all it's just another brick in the wall...

[Stormblade]

That would be awesome. The lag I get is basically on every looting. I always shift right click. When lootdestroyer is on this process takes maybe 5 seconds longer than normal. Doesn't seem like much but when your farming it adds to the time considerably.

[sarf]

PM me for an update (service only available when website is down).

Sarf
---
"Every election, Mickey Mouse looks better and better as President." - Duncan Long

[Shark]

Link dead since 2 days.

[Shark]

link dead since 2 days

[Stormblade]

Prob wanna update the title for this but anyway I found version .57 and installed that. Right now it's not actually destroying any items. It lets me add them to the list but that's it.

I saw in your notes that this was a bug in previous versions and that you fixed it but I should have the fixed version. Is there something I need to do extra? I wiped out the lootdestroyer directory. Maybe I need to destroy the Dynamic Data directory as well? I DID let it overwrite it all.

Edit: If I type /ldenable it destroys items in my inventory. But that seems to be the only time it does. It doesn't destroy everything even then. I had to type this multiple times and sometimes I got an error message saying I seem to be holding an item (I wasn't).

[sarf]

Yeah. The reason it's malfunctioning is because the "destroy item" code does not get called often enough and too often otherwise.

I'm trying to fix it.

Sarf
---
They are a puckish band of rapscallions

[juno]

Sorry to pester but I really want this add on since it seems extremely useful. Any updates?

[sarf]

Please try the newest version.

Sarf
---
A foolish consistency is the hobgoblin of little minds.

[Stormblade]

Got version mismatch errors for lootdestroyer and for Dynamic data after I installed the latest. Version in file was 4196. Manually changed Lootdestroyer and Dynamic Data to 4150 and all seems to be working well. It's removing stuff and I'm not getting the lag I used to get.

Good show! I also love how it's now compatible with AllinOneInventory which I use religiously.

[Anonymous]

I get a version mismatch when i try to load the latest version in my game addons list. any fixes?

[Stormblade]

I get a version mismatch when i try to load the latest version in my game addons list. any fixes?

Heh you must not have read my last message. Just change the .toc file and it's all good. Looks like he had it set for the EU version is all.

[sarf]

As Stormblade said - I make my AddOns for the EU version (hey, I live there! :) ). Change the .toc file version or use the version override thingy.

Sarf
---
"Technically, Windows is an 'operating system,' which means that it supplies your computer with the basic commands that it needs to suddenly, with no warning whatsoever, stop operating." - Dave Barry

[Anonymous]

thx that worked...

[OwlBoy]

As with the Bigger Quest Log Mod, I found that I wanted better art.

I felt this fit in with WoWs UI well:


http://www.owlboy.com/wow_gallery/Info%20Screens/loot_destroy_icon.gif (http://www.owlboy.com/wow_gallery/file/Info%20Screens/loot_destroy_icon.gif)


Use this File and replace the old tga in the Addon.

http://www.owlboy.com/UnwantedItem.zip

And Sarf, if you like it, feel free to add it to the mod, just note OwlBoy in your cerdits somewhere please. :)

-OwlBoy

[sarf]

Thanks OwlBoy!

Credits (and texture!) added! ;)

Update coming "soon" :)

Sarf
---
DELUSION, n. The father of a most respectable family, comprising Enthusiasm, Affection, Self-denial, Faith, Hope, Charity and many other goodly sons and daughters.

[waah]

hi, does this stil work i just dl it and tryed it it says i enabled it i have cosmoc i enables it that way and made a toggle key but i try to toggle it open and i get nothing any thoughts? i am using most up to date cosmos and L.D. v.061 ...... thanks for any feedback

[sarf]

You use it by shift-clicking items in the loot window - or control-clicking item in your inventory. LD will then terminate any such items it finds in your inventory (down to the number of items you have specified if you allow LD to preserve item counts).

Sarf
---
Everybody looks brave holding a machine gun.

[waah]

no i just need to know how to get teh toggle menu working...there is a bind key to menu and i bound a key and when ioress key it wont togle menu open or close ... and if you do thet how do oyu turn items back off

[sarf]

Menu?

There's very little GUI inherent in LootDestroyer.

Sarf
---
"Moral indignation is jealousy with a halo " - H.G.Wells

[waah]

Can anyone please update this to make it work i could really use this

[sarf]

As far as I know, LootDestroyer still works - do you experience otherwise?

Sarf
---
Any given program, when running, needs debugging. Any debugged program is obsolete.

[waah]

yes it says its out of date

[sarf]

Ah. Click the AddOns button in the character selection screen, then make sure that the option to ignore the version is checked.

If you go here:
http://www.fukt.bth.se/~k/wow/scripts/LootDestroyer/

and download v0.63 or newer they should work.

Sarf
---
Truly great madness cannot be achieved without significant intelligence.

[waah]

thanks m 8

[xbjim]

does this still work?

im trying it right now.. its adding items to the list, showing me a no smoking type sign in the loot window, but isnt destroying anything ive listed as unwanted.

[sarf]

Hmmm. Sorry for taking my sweet time in getting back to you - Midsummer's Eve was just celebrated here in Sweden (alcohol, BBQ and fish for the win!).

LootDestroyer should be working, but it may require Chronos/CosmosSchedule to actually *do* anything.

There were one other addon that exceeded LootDestroyer's functionality in that it analyzed the sell price of your inventory and could destroy the least valuable item.

Sarf
---
You know it's a bad morning when you get up out of bed and miss the floor.

[morbid_o]

There were one other addon that exceeded LootDestroyer's functionality in that it analyzed the sell price of your inventory and could destroy the least valuable item..

Holy crap! Any idea what this is called? If this ever showed up in cosmos I'd be ecstatic. I used lootdestroyer for a few days, but I prefer to keep all the items that i can until I get full bags. my understanding of lootdestroyer is that once i put an item on the LD list, I have to remove it to be able to pick-up that item later, which was just a pain.
This would be especially helpful now that my engineer is getting up in the skill world...

[sarf]

Hmm. I am considering writing that addon if it doesn't exist. SellValue has an item-window view that shows your items (sorted according to cost) which would make it easy to destroy stuff.

However, it'd be easier just to write an addon that popped up the SellValue window when your bags went empty.

Sarf
---
If at first you don't succeed, quit; don't be a nut about success.

[sarf]

Aaaaaand introducing SellValueAuto!

It slices, it dices, and it can turn your items to dust!

Anyhow, it is based on SellValue (actually, it requires SellValue to be present) and allows you to a) popup the inventory list (from SellValue) for manual destruction as well as automatic destruction of the cheapest item in your inventory.

For more info, go here:
http://www.fukt.bth.se/~k/wow/scripts/SellValueAuto/

As usual, this new addon is in early alpha. I'll prolly continue discussing it in this thread, but eventually SellValueAuto will do all you'd want to do.

Oh, and use /sva to summon the almighty power of SellValueAuto. By default, it does nothing (nada - zip, zilch and so on).

Sarf
---
Give me ambiguity or give me something else.

[morbid_o]

Awesome! thanks for this. I can't wait to try it out tonight in STV (skinning, skinning, skinning).
Hm, is SellValue in cosmos alpha? I can't remember if I've still got that one

[sarf]

SellValue is a seperate addon. If demand is great enough, I could prolly make it work with LootLink (no popup in that case, of course).

Sarf
---
The future ain't what it used to be.

[morbid_o]

Ok, I've had a chance to use it a bit, and i think it's great. I've mentioned it to a few other people also, and they like the idea as well. a few suggestions:
it would be nice if it were compatible with lootlink. I'm only saying this because I use Auctioneer and so I already have lootlink; sellvalue is sort of clutter at that point.
It would be nice to have an autoclose feature as well, that way when you destroy and item and loot an item, or when you walk away after deciding not to loot an item, the SellValueAuto window would close as well.

and, as always, a GUI would make things easy (part of Cosmos, maybe?), but I realize that you just wrote it.

nice work!

[sarf]

Sure, LootLink is far more than SellValue is. Please contact the SellValue author and get him to use LootLinks system (if present) and I'll be one happy duck.

However, if ONLY LootLink is present, there is no way for SellValueAuto to know what items not to sell. This will mean, as you level, that sooner or later your mining pick/blacksmith's hammer/skinning knife et cetera will get destroyed. This is because SellValueAuto does not contain the "do not sell list" - SellValues does.

I have added another command that will emulate /il <hide/show> during non-SellValue powered operation. This allows you to make sure that certain items are exempt from auto-destruction.

Note that popup functionality is not available if SellValues is not present (naturally).

Same address as before:
http://www.fukt.bth.se/~k/wow/scripts/SellValueAuto/

only v0.03 / v0.04

Sarf
---
Werd (http://www.dolem.com/images/wErd.jpg) - for the grammar impaired.

[morbid_o]

Sure, LootLink is far more than SellValue is. Please contact the SellValue author and get him to use LootLinks system (if present) and I'll be one happy duck.

According to the site, he/she is no longer developing SellValue. Any idea what might be involved in getting SellValue to use LootLink? I'm a novice when it comes to programming. C++, Java, and CSound are about all I know....

However, if ONLY LootLink is present, there is no way for SellValueAuto to know what items not to sell. This will mean, as you level, that sooner or later your mining pick/blacksmith's hammer/skinning knife et cetera will get destroyed. This is because SellValueAuto does not contain the "do not sell list" - SellValues does.
well, honestly, I don't use any auto-destroy. I'll often hold onto random vendor trash if I have the space. it's still nice functionality though.


I have added another command that will emulate /il <hide/show> during non-SellValue powered operation. This allows you to make sure that certain items are exempt from auto-destruction.

Note that popup functionality is not available if SellValues is not present (naturally).
so if I understand this correctly, I can type /il show to popup the same window that appears when I loot something with full bags? and, if I have sellvalue, I can mark items for non-destruction?

thanks again for writing this!

[sarf]

Nope. You can use the "/il <hide/show> Item Name" command to hide or show stuff from SellValue. SellValueAuto uses this functionality in the way that it will not destroy "hidden" stuff. I have also added an internal "do not destroy" list as well as an internal "please destroy this first" list.

It is this part of the /il command that SellValueAuto emulates. The window that pops up is part of SellValue and will not pop up unless SellValue is loaded. The only part that works with LootLink is the automatic destruction part.

To access the "please do destroy" list, use /svainc <item name>. This will add/remove <item name> from the list (depending whether it is present or not).

Sarf
---
If at first you don't succeed, try following the instructions.

[Pickled]

Think i'm going to cry! :(

This looks like a great addon:

I've installed the lastest cosmos and downloaded the latest lootdestroyer.

Problem: Everything works > everything enabled > added some items (shift+right click loot window item) >

BUT it dosen't delete any of the items upon looting !

Incidentally 5 of my guildmates tried it and had the same scenario, all is well but the thing wont delete any items!

Can anyone tell me what i'm doing wrong?

Regards

[Pickled]

To add: It notifies me etc what items are in the destroy list etc..

I've never seen the message like some have pointed out in the forum:

"X item was destroyed whatever message"..

[sarf]

SellValueAuto (clunky name - should be "DoStuffWhenInventoryFull") will not actually *do* anything UNTIL you get the error message "Inventory is full." Then it zips into action (if you've enabled it) and destroys the least expensive item (most probably a needed herb, unless you've configured it correctly :) ).

LootDestroyer will probably need Chronos/CosmosSchedule to work correctly.

Sarf
---
Good leaders are scarce, so I am following myself.

[Pickled]

Great!

Sounds like a step in the right direction:

As when WOW loads I get an error in the chat window saying something about Error: Cosmos.Schedule(ERRORSOMETHING) x3

Hmm I wonder..

[morbid_o]

sarf - can you change the /il <hide|show> so that one might shift+click the item that they want to hide or show? when i did it with chicken egg, it tried to hide [[Chicken Egg]], but when i typed it, all was fine.

[sarf]

Pickled, please give me the full message.

morbid_o, fixed in the latest version (available here (http://www.fukt.bth.se/~k/wow/scripts/SellValueAuto/)).

Sarf
---
Everything you know is wrong!

[Pickled]

Hi Sarf:

Not at my WoW computer right now... but I remember briefly the error now upon loading into the world I get 4 messages all the same:

Cosmos.Shedule error: Passed a nil handler
Cosmos.Shedule error: Passed a nil handler
Cosmos.Shedule error: Passed a nil handler
Cosmos.Shedule error: Passed a nil handler

I'll post it word for word when I get home, but thats pretty much it.

It does not seem to make reference to any line of code as I'm aware..

[Pickled]

Ok heres the exact message:

ERROR: Nil handler passed to Cosmos.Schedule()

[sarf]

Pickled, get a new version of DynamicData, Chronos and Sea.

Better yet, use SellValueAuto instead of lootdestroyer. :)

Sarf
---
Just as Schopenhauer predicted, absolutely nothing is happening.

[morbid_o]

Hmm..stil put [[]] around it for me, but I'll re-download tonight and try again. pretty soon I'm going to have all my friends using this as well. (although I can see the girlfriend complaining now that she has to use a slash command on load...lol)

[Stormblade]

Pickled, get a new version of DynamicData, Chronos and Sea.

Better yet, use SellValueAuto instead of lootdestroyer. :)

Sarf
---
Just as Schopenhauer predicted, absolutely nothing is happening.Getting the latest Chronos ie the one that's in the latest Cosmos did not work and continued to give that error Pickled experienced. However, I downloaded an older version from curse-gaming dated 06/14/2005 which currently is the latest they have listed and this works. It's removing items once again.

Just thought this might help. I like lootdestroyer and the control I have. Fits me perfect. I haven't tried SellValueAuto but unless it maintains a list that I can modify I'm not interested. Deleted based on value isn't a good idea for me personally.

[morbid_o]

It has an inventory list that you can opt to show/hide items from.

however, I still can't type /il hide (shift+click item)

[fryguy451]

I like lootdestroyer and the control I have. Fits me perfect. I haven't tried SellValueAuto but unless it maintains a list that I can modify I'm not interested. Deleted based on value isn't a good idea for me personally.

I second that...

Sarf, would you be willing to update lootdestroyer to work with khaos/least comsos ?

Thanks.

[Stormblade]

Well, with the 1.7 patch lootdestroyer doesn't want to remember it's settings which means each time I log on I have to remember to enable it.

Is it possible that it could be updated to do this? I really like this addon and have not found any other addon to give me the same control.

If this addon is dead perhaps it could be given to someone? Or perhaps an alternative addon with the same functionality exists? My main thing is I want to be able to add / remove items from a list and have the addon remove ONLY what's on that list.

Any other features are gravy like maybe different criteria to remove things such as based on cost or something. I just want to be able to tell it exactly the things I want deleted.

[fryguy451]

I've found a few that are some what similar, but nothing as easy and specific as LootDestroryer...

I currently use this one, tho it has to be modified for the keybindings

EasyDestroy http://www.curse-gaming.com/mod.php?addid=692

[fryguy451]

I've found a few that are some what similar, but nothing as easy and specific as LootDestroryer...

I currently use this one, tho it has to be modified for the keybindings

EasyDestroy http://www.curse-gaming.com/mod.php?addid=692

An updated version of EasyDestroy here http://ui.worldofwar.net/ui.php?id=1505

[fryguy451]

A new alternative is here: Trash-O-Matic http://www.wowinterface.com/downloads/fileinfo.php?id=4280

Edit:
It appears that this one requires Timex, but Timex seems to conflict with Chronos and I don't have a workaround :/