ActionButton Unabridged v0.34

[sarf]

EDIT:
Upgraded it to new Interface version. Might be non-working. Optionally dependent on Cosmos (options should work now).
Fixed errors.
Added handling of Cosmos peek-a-boo (e.g. Cosmos not present on init, but present on rest of program).

Hiya!


This AddOn presents unabridged information in the tooltip when you mouseover abilities/spells in the action bars. It was inspired by Bayta's thread (http://www.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=7287) on the official UI board.

Use the following code to enable it if you do not run Cosmos (slash commands are available) :/script ActionButtonUnabridged_Toggle_Enabled(1);

The files are available here :
http://www.fukt.bth.se/~k/wow/scripts/ActionButtonUnabridged/

Hope this works!

Feedback et cetera to this thread.

Sarf
---
If you try and don't succeed, cheat. Repeat until caught. Then lie.

[karconn]

oooo testing!

Oh, you forgot to put them inside a 'ActionButtonUnabridged' folder inside your zip...there's no 'barrier', so to speak, between 'AddOns' and the raw files :)

[karconn]

Ok, here's the error I get when I try to hover over an ability (I tested with Find Herbs):

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 144
Error : attempt to call global `ActionButtonUnabridged_FindThingByNameAndRank' (a nil value)

And here's the error I get with spells:

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 187
Error : attempt to call global `find' (a nil value)

I also get the 'line 187' error when I hover over non-spell items, like I have a hotkeyed Gem-Studded Belt, or a potion.

[sarf]

Fixed both errors (I hope).

Sarf
---
ELOQUENCE, n. The art of orally persuading fools that white is the color that it appears to be. It includes the gift of making any color appear white.

[karconn]

Still get the same errors when I hover. Also noticed when I try to add food to the bar, I get the following error:

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 268
Error : bad argument #2 to `find' (string expected, got nil)

Also, by default it is not enabled, and the slash command wasn't listed so I cheated and looked in the lua. The first time you do /abuenable it flips to 'disabled' (even though it's really not enabled when you first reloadui), then you do it again and it's 'enabled', and then the errors occur.

If I disable the feature, everything works ok again, I can drop things on the bar and hover like normal.

btw - I'm just doing a console 'reloadui' after pasting each new folder of code in, hope that is sufficient :)

[sarf]

Try the new version and present any errors to me again :)

Sarf
---
Error in operator: add beer

[karconn]

Hovering over spell or item (items get the same errors as spells now):

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 187
Error : bad argument #1 to `find' (string expected, got nil)

When trying to put something on the action bar:

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 268
Error : bad argument #2 to `find' (string expected, got nil)

[sarf]

Ah. My bad. I've fixed the first error and added some debug output. Please tell me what it says.

Sarf
---
Good girls are bad girls that never get caught.

[karconn]

Ok...

1) Still have to do /abuenable twice to disable/enable to fire it up, but I'm sure you knew that and it's low priority at this point in testing, just a reminder :)

2) None of the tooltips actually work at this point, but again I'm assuming this was intentional, to cut it back to read just the pop-up msgs...

3) So when I hover over an 'item' or a 'spell', nothing happens. I get no feedback in chat. When I hover over an 'ability' or oddly enough a 'macro' I get the following debug info:

ABU: Tooltip was empty
ABU: Could not retrieve spell from tooltip

[sarf]

Fixed 1 (for sure!)

Hope I've fixed the problems.

Sarf
---
If vegetarians eat vegetables, I guess that makes me a humanitarian.

[karconn]

/abuenable no definately says it turns it on the first time. I come in disabled. Other than that, it doesn't seem to do anything at all now :(

I don't get chat debug info, no errors, and the mouse overs don't have any more information than they do usually. Tested items, macros, spells, abilities. Added some food to an empty bar to see if any msgs or errors were caused by that - nothing.

[sarf]

OK. I added some debug info.

Also, started to make it possible to fix sidebars/secondactionbar.

Sarf
---
Why do hair shampoo instructions say 'Lather. Rinse. Repeat'? If you did this, would you ever be able to stop?

[sarf]

Updated the code. There is now a slight possibility that it might work.

Sarf
---
If electricity comes from electrons, does morality come from morons?

[karconn]

Ok with this version the chat window tells me the name of the thing I'm hovering over. Seems to work just fine for everything (items, macros, spells, abilities).

Am I correct in assuming at this point I shouldn't be seeing nice big popups with lots of information? Because I'm not yet :)

[sarf]

Try out the new version, now with even more debug info.

:)

Sarf
---
If Superman is so smart, why does he wear his underpants over his trousers?

[karconn]

Whew, ok here goes:

ABU: Found spell name. Spell 'Healing Touch'
Found matching spell. (<- I believe 9 lines of this)
Failed to find spell in spellbook 'spell'.
Failed to find spell in spellbook 'ability'.
Failed to find spell in spellbook 'pet'.

Oh I see why the 9x, I have 9 various ranks of the same spell called 'Healing Touch'. If I do Faerie Fire, I only get 3 lines of 'Found matching spell'.

[sarf]

Try version 19 (http://www.fukt.bth.se/~k/wow/scripts/ActionButtonUnabridged/ActionButtonUnabridged_v0.19.zip). If it works, blame my ego for thinking I could extract the rank.

If version 19 (http://www.fukt.bth.se/~k/wow/scripts/ActionButtonUnabridged/ActionButtonUnabridged_v0.19.zip) works, you can actually use version 20 (http://www.fukt.bth.se/~k/wow/scripts/ActionButtonUnabridged/ActionButtonUnabridged_v0.20.zip) (without a lot of debug info).

Sarf
---
If you throw a cat out a car window, does it become kitty litter?

[karconn]

Well define 'works'? :)

It still has debug information, I see you added writing out the rank of the spell, but it still comes back and spouts the 3 "can't find spell in spellbook blah" messages?

Does that mean it works or should I not try 20?

[karconn]

I guess what I mean is that it doesn't pop up any special UI when I mouse over the buttons yet, so I'm assuming that means it doesn't work yet?

I can't tell if these versions are just for me to report on the chat text or if I should also be seeing popups at this point :)

[sarf]

No, then it does not work. :(

Sarf
---
Can I yell MOVIE in a crowded firehouse?

[sarf]

Try version 21.

Bleh. Stupid bug by yours truly probably caused it all to fail. :(

Sarf
---
Isn't Disney World a people trap operated by a mouse?

[karconn]

ooo much closer!

Everything works (including my gem-studded belt) and potions, but there's two things on my Druid that aren't showing up...and I'm tempted to go log in my Hunter really quick to see if all the things like the animal training and taming (with the really long discriptions in the abilities section) come up.

First, the 'attack' button has a pop up for your crit chance, that doesn't show if you have it hotkeyed (I don't anymore, I like to use T, but just throwing it out there).

Second, my Find Herbs still just says 'Find Herbs'. Now, if you don't know what find herbs does, I suppose you are fairly lost anyways, but now I'm starting to wonder if we're missing a class of item that isn't showing for some reason?

Other than those 2 things I've seen so far, everything else is most verbose! Excellent! I'm going to go try my Hunter and look at some of those abilities. Should check the pally, but I'm sure all the seals will work.

[karconn]

Ok, just looked a the Hunter and I think I see the common problem.

Things that you can hotkey which don't have a rank seem to be the ones which aren't showing up.

So like 'Aspect of Monkey' has no rank, so I don't get a long version. My 'Aspect of Hawk' has a Rank 1, so I see the detailed text.

None of the other pet things (especially the nice ones we'd like to see about when to feed your pet and all that) are showing up, presumably because they too have no rank.

Hope that helps :)

[karconn]

Oh, and this one could definately use a toggle that saved the last state :)

[sarf]

The toggle isn't persistant?

Darn...

Well, I've made one last patch. Try it and see... but check out so that Find Herbs actually has a description. :)

Sarf
---
I hate myself to sleep at night

[karconn]

It does have a little description, and did you see my comments about all the hunter abilities? Especially the comparison of the two 'aspects'? Both have long descriptions, yet the one isn't displayed, and I'm suspect it is no coincidence that it, like all the pet related abilities, has no rank.

[karconn]

The new patch isn't any different. It still doesn't show descriptions for items in the books that don't have ranks, which are draggable to the button bar.

But you are in Europe so it must be like 2am or something there? Get some sleep, made lots of good stuff today :D

[sarf]

Well, it should handle rank-less skills/spells too.

:/

Made it more moronic so there's less to break.

Sarf
---
Support bacteria. They're the only culture some people have.

[karconn]

Still appears as though spells or abilities without rank are not showing any additional information :(

[sarf]

Version 24 might fix that.

Sarf
---
Did you know that if you were a kangaroo, you couldn't be a mailman?

[karconn]

Woohoo!

It's working now :)

Sooo...will we get a friendly check in the Cosmos menu to turn it on? :mrgreen: Or at the very least, have it save the status? Actually...let me check that, maybe you put it in already...

...nope, doesn't save yet.

Going over to read if there are any updates for the ALT button. Might not be as responsive testing today, I finally got fed a few contracting jobs to work on, but if I get bogged down with work I'll at least try to come out and test every hour. :)

[sarf]

Hehe :) Good that it works - just to be sure, it works with SecondBar/SideBar too, right?

The non-saving issue is odd.

Can you tell me if your SavedVariables.lua file (should be somewhere in your WoW directory and subdirs contains any reference to COS_ABUNABRIDGED_ENABLED_X ?

Sarf
---
Death is an illusion. Life is a hallucination. Taxes are objective reality.

[karconn]

Ok, works with the 2nd bar, does 'not' work on the side bars.

btw - how does the 2nd bar work? I don't use it, I suppose, mostly because I didn't get how to activate them with the keyboard?

And with respect to saved variables, here's everything I have:


CosmosMaster_CVars = {
["COS_INVM_SEPARATOR_X"] = 0,
["COS_DAMAGE_REDUCTION_TEXT"] = 1,
["COS_COMCALLER_HEALTHSLIMIT"] = 0.2,
["COS_WHOLINK_ALTINVITE_X"] = 0,
["COS_ITEMBUFF_SEPARATOR"] = 1,
["COS_VICKEL_WATCHCOSMOS_X"] = 0,
["COS_COMCALLER_COOLDOWN_X"] = 0,
["COS_SIDEBARL"] = 1,
["COS_CLOCK_TWENTYFOUR_HOURS"] = 1,
["COS_QUESTSCROLL_X"] = 1,
["COS_PLAYERHPMPXPTXT"] = 1,
["COS_VICKEL_HEADER_X"] = 0,
["COS_SEELEVEL_X"] = 1,
["COS_TSH_DISPLAY_QUEUE"] = 1,
["COS_LOOKLOCK_STRAFE_X"] = 0,
["COS_WHOLINK_A"] = 1,
["COS_AE_LOADERROR"] = "0",
["COS_QUESTMINION_AUTOADD"] = 1,
["COS_QUICKLOOT"] = 1,
["COS_CLOCK_OFFSET_X"] = 0,
["COS_DPS"] = 1,
["COS_THOTTBOT_ON"] = 1,
["COS_THOTTBOT_HY_X"] = 0,
["COS_AE1"] = "",
["COS_QUESTMINION_REMOVECOMPLETE_X"] = 1,
["COS_LOOKLOCK_HEADER_X"] = 0,
["COS_CHATTS_COMBAT_ENABLED_X"] = 0,
["COS_VICKEL_WATCHCOSMOS_PARTY"] = 1,
["COS_DAMAGE_REDUCTION_TEXT_X"] = 1,
["COS_RELOC_TOOLTIP_X"] = 0,
["COS_SIDEBARHEADER_X"] = 0,
["COS_PARTYSHOWBUFF"] = 1,
["COS_INVM_SEPARATOR"] = 1,
["COS_GAMES_USECUSTOM_X"] = 0,
["COS_AE3"] = "",
["COS_PARTYHPTXT_X"] = 0,
["COS_CLOCK_RESET_POSITION"] = 0,
["COS_QUICKLOOT_HIDE_X"] = 1,
["COS_SHIFTSELL"] = 1,
["COS_RELOC_TOOLTIP"] = 1,
["COS_THOTTBOT_ON_X"] = 0,
["COS_GAMES_USECUSTOM"] = 1,
["COS_TSH_SECTION"] = 1,
["COS_WHOLINK_COLOR_X"] = 1,
["COS_ITEMBUFF_ON_X"] = 1,
["COS_AE2"] = "",
["COS_VICKEL_IDLESPEED_X"] = 1,
["COS_WHOLINK_BRACE_X"] = 1,
["COS_LOOKLOCK_HEADER"] = 1,
["COS_QUESTMINION_AUTOHIDE_X"] = 1,
["COS_AE_STANCE"] = 1,
["COS_SIDEBARR_X"] = 0,
["COS_WHOLINK_SEP_X"] = 0,
["COS_AE_SECTION"] = 1,
["COS_MOOBUFFMOD_X"] = 1,
["COS_ENABLEQUESTSHARE"] = 0,
["COS_COMCALLER_HEADER"] = 1,
["COS_AE_SECTION_X"] = 0,
["COS_DPS_REPORT"] = 1,
["COS_INVM_LOOTTOGGLE"] = 1,
["COS_CHATTS_SEPARATOR_X"] = 1,
["COS_SIDEBARHEADER"] = 1,
["COS_WHOLINK_SEP"] = 1,
["COS_SECONDBAR"] = 1,
["COS_INVM_ENABLE"] = 1,
["COS_VICKEL_TOGGLE_X"] = 0,
["COS_WHOLINK_SHIFTWHO_X"] = 1,
["COS_VICKEL_TOGGLE"] = 1,
["COS_QUESTMINION_COLOROPTION_QUESTTITLE"] = 1,
["COS_VICKEL_WATCHCOSMOS_PARTY_X"] = 0,
["COS_TARGETDISTANCE_X"] = 1,
["COS_THOTTBOT_PT"] = 1,
["COS_CHATTS_ENABLED"] = 1,
["COS_TSH_ENABLE"] = 1,
["COS_DEFAULTSEPARATOR_X"] = 0,
["COS_SECONDBAR_SKIN_X"] = 0,
["COS_THOTTBOT_HY"] = 1,
["COS_INVM_ENABLE_X"] = 0,
["COS_WHOLINK_C"] = 1,
["COS_VICKEL_HEADER"] = 1,
["COS_CLOCK_RESET_POSITION_X"] = 0,
["COS_QUESTSHARE_SECTION"] = 1,
["COS_WHOLINK_A_X"] = 1,
["COS_THOTTBOT_PP"] = 1,
["COS_WHOLINK_C_X"] = 1,
["COS_QUESTMINION_COLOROPTION_QUESTSTATUS"] = 1,
["COS_ITEMBUFF_SEPARATOR_X"] = 0,
["COS_SIDEBARL_X"] = 0,
["COS_PARTYHPTXT"] = 1,
["COS_LOOTDESTROYER_ENABLED_X"] = 1,
["COS_ENABLEQUESTSHARE_X"] = 1,
["COS_QUESTSCROLL"] = 40,
["COS_CLOCK_TWENTYFOUR_HOURS_X"] = 0,
["COS_INVM_LOOTTOGGLE_X"] = 0,
["COS_LOOKLOCK_TOGGLE"] = 1,
["COS_THOTTBOT_SECTION_X"] = 0,
["COS_GAMES_SEP"] = 1,
["COS_QUESTMINION_COLOROPTION_QUESTTITLE_X"] = 0,
["COS_DPS_SECTION"] = 1,
["COS_CLOCK_SECTION"] = 1,
["COS_COMCALLER_MANASLIMIT_X"] = 0,
["COS_SECONDBAR_PAGES_X"] = 0,
["COS_COMCALLER_HEALTHSLIMIT_X"] = 0,
["COS_VICKEL_IDLESPEED"] = 5,
["COS_VICKEL_WATCHCOSMOS"] = 1,
["COS_DPS_X"] = 0,
["COS_CHATTS_COMBAT_ENABLED"] = 0,
["COS_PLAYERHPMPXPTXT_X"] = 0,
["COS_COMCALLER_COOLDOWN"] = 30,
["COS_WHOLINK_COLOR"] = 1,
["COS_TSH_DISPLAY_QUEUE_X"] = 1,
["COS_AE_SETS"] = 0,
["COS_TSH_SECTION_X"] = 0,
["COS_SIDEBARR"] = 1,
["COS_DEFAULTSEPARATOR"] = 1,
["COS_THOTTBOT_PT_X"] = 0,
["COS_QUESTSHARE_SECTION_X"] = 0,
["COS_COMCALLER_HEADER_X"] = 0,
["COS_THOTTBOT_SECTION"] = 1,
["COS_HEADER"] = 1,
["COS_WHOLINK_BRACE"] = 1,
["COS_QUESTMINION_COLOROPTION_QUESTSTATUS_X"] = 1,
["COS_QUICKLOOT_X"] = 1,
["COS_LOOKLOCK_TOGGLE_X"] = 1,
["COS_QUESTMINION_SECTION"] = 1,
["COS_TSH_ENABLE_X"] = 1,
["COS_DPS_REPORT_X"] = 0,
["COS_HEADER_X"] = 0,
["COS_AE_STANCE_X"] = 0,
["COS_SECONDBAR_X"] = 0,
["COS_WHOLINK_SHIFTWHO"] = 1,
["COS_ITEMBUFF_ON"] = 1,
["COS_GAMES_SEP_X"] = 0,
["COS_THOTTBOT_PP_X"] = 0,
["COS_SECONDBAR_PAGES"] = 1,
["COS_QUESTMINION_SECTION_X"] = 0,
["COS_QUICKLOOT_ONSCREEN_X"] = 1,
["COS_CLOCK_SECTION_X"] = 0,
["COS_QUESTMINION_AUTOADD_X"] = 1,
["COS_CLOCK_ENABLE_X"] = 1,
["COS_DPS_SECTION_X"] = 0,
["COS_COMCALLER_MANASLIMIT"] = 0.2,
["COS_CHATTS_ENABLED_X"] = 1,
["COS_SHIFTSELL_X"] = 0,
["COS_CLOCK_ENABLE"] = 0,
["COS_PARTYSHOWBUFF_X"] = 0,
["COS_SEELEVEL"] = 1,
["COS_AE4"] = "",
["COS_CLOCK_OFFSET"] = 0,
}

[sarf]

You do get the options in the Cosmos options for ABU, right?

The Second Action Button has its own bindings that you can assign to whatever keys you want.

Sarf
---
Damn the torpedoes.

[sarf]

EDIT:
New version up, should fix the tooltips for the SideBars.

Even more newer version up which should fix the Cosmos issue (partially).

Note that if you do not see any Cosmos options, but you have Cosmos installed, the problem with the options not saving is an issue until OptionalDeps is fixed... I can do a hack to fix it however.

Sarf
---
Cthulhu saves our souls and redeems them for valuable coupons later.

[karconn]

.26 has the following error as I try to hover over the standard button bar. Haven't tried the 2nd and side bars yet because of this error:

String : Interface\AddOns\ActionButtonUnabridged\Act...
Line : 271
Error : attempt to concatenate local `TooltipNameBase' (a table value)

Well, OptionalDeps doesn't need to be 'fixed'...it needs to be 'implemented' :) They said that was something that was going to go into the next patch, whenever that comes around. I see dependencies is nil, any reason not to make that Cosmos until they implement OptionalDeps? This 'is' going to be an official Cosmos thingy right? :)

[sarf]

.26 has the following error as I try to hover over the standard button bar. Haven't tried the 2nd and side bars yet because of this error:
[snip]
Fixed that error and uploaded new version. New version will be better at integrating itself with Cosmos.

Well, OptionalDeps doesn't need to be 'fixed'...it needs to be 'implemented' :) They said that was something that was going to go into the next patch, whenever that comes around. I see dependencies is nil, any reason not to make that Cosmos until they implement OptionalDeps? This 'is' going to be an official Cosmos thingy right? :)
Well, mainly because this is a stand-alone AddOn... it could (theoretically) be used without Cosmos.

Sarf
---
Beyond good and evil lies North Dakota.

[karconn]

I'll test it again. I guess since the LootDestroyer has a checkbox in the Cosmos menu, I just assumed you were working with them and that all this stuff was going to show up in alpha soon :(

[sarf]

I'll test it again. I guess since the LootDestroyer has a checkbox in the Cosmos menu, I just assumed you were working with them and that all this stuff was going to show up in alpha soon :(
Well... that's up to the Cosmos developers. I'm mainly a bug/issue handling fella in the Cosmos team, and while I do provide feedback (and bug reports) to the Cosmos team, I do not have access to the Cosmos repository (or SVN) basically because I can't test the code I would provide.

Essentially, sooner or later, I suspect that my AddOns will get incorporated into Cosmos, but the thing is that I would prefer avoiding to bloat Cosmos until the day when the users themselves can (easily) choose their own preferred AddOns.

Besides, if my code got incorporated in Cosmos it would be somewhat harder for me to "get at it" currently.

Sarf
---
"I was part of that strange race of people aptly described as spending their lives doing things they detest to make money they don't want to buy things they don't need to impress people they dislike." - Emile Henry Gauvreay

[karconn]

Ok, it works with the right toolbar, it 'sorta' works with the left. The tooltip of the left bar pops up and hides in like a half a second, but I can see the full text there, just like the right toolbar.

With respect to /abuenable. It doesn't save the setting. When I first come in it's effectively disabled. If I look at the Cosmo checks, I don't see a check for it (like it isn't registered yet). If I do /abuenable, it turns it on, and when I look in Cosmos settings, there it is at the bottom, but unchecked. So there is some weirdness happening there, and it doesn't save :)

[sarf]

Ok, it works with the right toolbar, it 'sorta' works with the left. The tooltip of the left bar pops up and hides in like a half a second, but I can see the full text there, just like the right toolbar.
Hmm... alright, I'll see if there's something I can do.

With respect to /abuenable. It doesn't save the setting. When I first come in it's effectively disabled. If I look at the Cosmo checks, I don't see a check for it (like it isn't registered yet). If I do /abuenable, it turns it on, and when I look in Cosmos settings, there it is at the bottom, but unchecked. So there is some weirdness happening there, and it doesn't save :)
OK, I've fiddled around a bit and it might work now.

Check out the new version.

Sarf
---
"All progress is based upon a universal innate desire on the part of every organism to live beyond its income." - Samuel Butler

[karconn]

The left action bar works now.

Still the same behavior with respect to the Cosmos settings menu and it not saving the setting between sessions and needing to do /abuenable when you log a character in to a) enable it and b) get the switch to show up in the menu.

Great stuff so far, got a phone conference in about 15 minutes so I'll be offline for a few hours at that point. :)

[sarf]

The left action bar works now.
Great!

Still the same behavior with respect to the Cosmos settings menu and it not saving the setting between sessions and needing to do /abuenable when you log a character in to a) enable it and b) get the switch to show up in the menu.
Hmm... ouch. OK, quick fix time.

<WHAM BONK WHACK>

Update complete, see if it works now.

Sarf
---
"Money is like muck, not good except it be spread." - Francis Bacon, The Essays or Counsels

[karconn]

Still the same, have to do /abuenable to get it to turn on and show up in the Cosmos options, and it doesn't save. :(

[sarf]

You know what?

I'll skip the saving part for now. Too frustrating. :)

Anyhow, if you want to enable my AddOns by default, just look for the AddOnName_Enabled = 0 in AddOnName.lua and change the 0 into a 1.

Sarf
---
Hard work has a future payoff. Laziness pays off now.

[karconn]

kk...and thanks for all the good stuff :D

[karconn]

Found a new little problem with this. I tried setting the following:

ActionButtonUnabridged_Enabled = 1;

So I wouldn't have to enable it each time and something interesting happens. It's in theory enabled, but it's not really on at that point. I have to do /abuenable 'twice' to turn it off and back on again for it to work.

So even though I enable it by setting that variable 'before' it loads, it doesn't seem to recognize the setting on loading, if that makes sense. It just treats it as 'off'.

I'm going to see if this is true with alt-self-cast as well...

[sarf]

Tell you what.

Add ModName_Enabled_Toggle(1); at the end of the OnLoad() method in each file instead... the problem is that even though it is enabled, other stuff (like hooking into methods) haven't been done yet, so it's better to do a forced toggle after the AddOn has initialized.

Hence:
function ActionButtonUnabridged_OnLoad()
ActionButtonUnabridged_Register();
end
becomesfunction ActionButtonUnabridged_OnLoad()
ActionButtonUnabridged_Register();
ActionButtonUnabridged_Toggle_Enabled(1);
end
This will work.

I hope.

Sarf
---
All in all it's just another brick in the wall...

[karconn]

ok alt-self-cast is fine. If I force the setting to enabled in the lua in that add-on, it works when I come in.

This one seems to ignore it for some reason.

I was looking at the lua...and there's a lot of references to lootdestroyer variables in there, maybe you stole some code from that one and forgot to change a few variables? Like some of the slash commands being registered are from loot destoryer...and OnEvent references "LootDestroyer_CosmosRegistered"?

Just thinking of ideas. :)

[karconn]

Tell you what.

Add ModName_Enabled_Toggle(1); at the end of the OnLoad() method in each file instead... the problem is that even though it is enabled, other stuff (like hooking into methods) haven't been done yet, so it's better to do a forced toggle after the AddOn has initialized.

Hence:
function ActionButtonUnabridged_OnLoad()
ActionButtonUnabridged_Register();
end
becomesfunction ActionButtonUnabridged_OnLoad()
ActionButtonUnabridged_Register();
ActionButtonUnabridged_Toggle_Enabled(1);
end
This will work.

I hope.

Sarf
---
All in all it's just another brick in the wall...


Oh...ok :)

[karconn]

Guess the hired help is becoming a pain :(

[sarf]

ok alt-self-cast is fine. If I force the setting to enabled in the lua in that add-on, it works when I come in.
They work differently... though AltSelfCast should not work.

This one seems to ignore it for some reason.
Not ignoring it, but if you check out the Toggle_Enabled function, you see that they do lots of stuff. This stuff does not get done if you simply set _Enabled = 1;. :)

I was looking at the lua...and there's a lot of references to lootdestroyer variables in there, maybe you stole some code from that one and forgot to change a few variables? Like some of the slash commands being registered are from loot destoryer...and OnEvent references "LootDestroyer_CosmosRegistered"?
Eek!

Err...

My bad.

Updated the code.

Sarf
---
All biography is ultimately fiction.

[sarf]

Guess the hired help is becoming a pain :(
Eh? What? Nonono... my bad for misinforming you what you should do.

By the way, have you tested LootDestroyer v0.35 yet? :P

Sarf
---
All Wood? Oh! AL Wood. I didn't see the missing "L" at first.

[karconn]

didn't see a .35, i'll go look :)

uhm, ok added the function call to toggle it on in the OnLoad for unabridged and that works fine.

and yes, all i had to do for alt-self was set the variable to 1 and it works on load :p

hmm...unless the save for that one is working? I dunno, it seems to work, i'm happy :D

lemme go look at .35 :)

[karconn]

ooo unabridged setting in Cosmos seems stable and it seems to 'save' the settings between sessions now...and it seems to loadup as it should based on your last setting :)

[sarf]

Nice! Um... I hope it was something I did. :)

Sleeptime!

Sarf
---
Imagination was given to man to compensate him for what he isn't, and a sense of humor to console him for what he is.